Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13649 )
Change subject: [tools] Add get/set extra-configs for CLI tools ...................................................................... Patch Set 3: (5 comments) Thanks for comments. I added some tests and changed the names of some variables. :) http://gerrit.cloudera.org:8080/#/c/13649/2/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/13649/2/src/kudu/tools/kudu-admin-test.cc@2259 PS2, Line 2259: // Gets extra-configs when no extra config set. : { : string stdout, stderr; : Status s = RunKuduTool({ : "table", : "get_extra_configs", : master_address, : kTableId : }, &stdout, &stderr); : ASSERT_TRUE(s.ok()) << ToolRunInfo(s, stdout, stderr); : ASSERT_EQ(stdout, " Configuration | Value\n" : "---------------+-------\n"); : } : : // Sets "kudu.table.history_max_age_sec" to 3600. : { : ASSERT_TOOL_OK( : "table", > Could you also test the behavior when: Done http://gerrit.cloudera.org:8080/#/c/13649/2/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/13649/2/src/kudu/tools/tool_action_table.cc@86 PS2, Line 86: config_names, "", : "Comma-separated list of configurations to display. " : "An empty value displays all conf > nit: "tag" is a little vague since we don't use it anywhere currently. How Done http://gerrit.cloudera.org:8080/#/c/13649/2/src/kudu/tools/tool_action_table.cc@449 PS2, Line 449: Con > nit: How about "Configuration" and "Value"? Done http://gerrit.cloudera.org:8080/#/c/13649/2/src/kudu/tools/tool_action_table.cc@566 PS2, Line 566: value > nit: lower case Done http://gerrit.cloudera.org:8080/#/c/13649/2/src/kudu/tools/tool_action_table.cc@573 PS2, Line 573: > nit: We're not altering the table here. Perhaps: Done -- To view, visit http://gerrit.cloudera.org:8080/13649 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90c790bbfe41a59f621157ff6b3f11d2b8f916e7 Gerrit-Change-Number: 13649 Gerrit-PatchSet: 3 Gerrit-Owner: Yao Xu <oclarms....@gmail.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <oclarms....@gmail.com> Gerrit-Comment-Date: Wed, 19 Jun 2019 08:14:56 +0000 Gerrit-HasComments: Yes
