Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13681 )
Change subject: KUDU-2870: allow super-user to skip authz checks in Checksum ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13681/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/13681/2/src/kudu/tserver/tablet_service.cc@887 PS2, Line 887: bool TabletServiceImpl::AuthorizeChecksum(const google::protobuf::Message* req, : google::protobuf::Message* resp, : rpc::RpcContext* context) { : if (FLAGS_tserver_enforce_access_control) { : return server_->Authorize(context, ServerBase::SUPER_USER); : } : return AuthorizeClient(req, resp, context); : } > As for the test, you can just disable corresponding scenarios for a while, I realized that we don't need the FLAGS_checksum_require_authz_token flag if, similar to what you suggest, we let super users skip fine-grained authz checking. http://gerrit.cloudera.org:8080/#/c/13681/2/src/kudu/tserver/tserver_service.proto File src/kudu/tserver/tserver_service.proto: http://gerrit.cloudera.org:8080/#/c/13681/2/src/kudu/tserver/tserver_service.proto@54 PS2, Line 54: : rpc Checksum(ChecksumRe > I see. Then, maybe, remove the new part of the comment to avoid confusion? Done -- To view, visit http://gerrit.cloudera.org:8080/13681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9da21f41702da747a081ab037d75865748d981a8 Gerrit-Change-Number: 13681 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 20 Jun 2019 01:10:00 +0000 Gerrit-HasComments: Yes
