Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 )
Change subject: [maintenance] Add extra config for maintenance manager task priority ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13659/1/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: http://gerrit.cloudera.org:8080/#/c/13659/1/src/kudu/common/wire_protocol.cc@681 PS1, Line 681: int32_t maintenance_priority; : if (!safe_strto32(value, &maintenance_priority)) { : return Status::InvalidArgument(Substitute("Unable to parse $0", name), value); : } Maybe we can optimize the duplicate code here. -- To view, visit http://gerrit.cloudera.org:8080/13659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867 Gerrit-Change-Number: 13659 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yao Xu <oclarms....@gmail.com> Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Sat, 22 Jun 2019 02:54:55 +0000 Gerrit-HasComments: Yes
