Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 )
Change subject: KUDU-2851: modify table scan and copy tools to surface errors ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/13733/3//COMMIT_MSG Commit Message: PS3: > So it'll be clear when looking back through old commits, could you also men Done http://gerrit.cloudera.org:8080/#/c/13733/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/13733/3/src/kudu/tools/kudu-tool-test.cc@5028 PS3, Line 5028: ser > nit: Can you remove the extra whitespace here? Same below, and above in pat Done http://gerrit.cloudera.org:8080/#/c/13733/3/src/kudu/tools/kudu-tool-test.cc@5035 PS3, Line 5035: enfo > nit: this is the copy tool :) Done http://gerrit.cloudera.org:8080/#/c/13733/3/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/13733/3/src/kudu/tools/table_scanner.cc@628 PS3, Line 628: : sw.stop(); : if (out_) { : *out_ << "Total count " << total_count_.Load() : << " cost " << sw.elapsed().wall_seconds() << " seconds" << endl; : } : > Looking at TableScanner's out_ a bit, it's possible that `out_` never gets Done -- To view, visit http://gerrit.cloudera.org:8080/13733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic45da537b8bacfa9625010536ea82da9a6e76100 Gerrit-Change-Number: 13733 Gerrit-PatchSet: 5 Gerrit-Owner: Hannah Nguyen <hannah.ngu...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hannah Nguyen <hannah.ngu...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 27 Jun 2019 00:18:32 +0000 Gerrit-HasComments: Yes
