Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13750 )
Change subject: KUDU-2876 Audit the semantics and the usage of Tabet::GetComponents ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13750/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13750/1//COMMIT_MSG@7 PS1, Line 7: Audit the semantics and the usage > I'm curious: did you trace the usages of the updated > GetComponents() method to make sure the semantics of the callsites > don't assume nullable output parameter as a result? Yes, I'm sure. :) http://gerrit.cloudera.org:8080/#/c/13750/1/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/13750/1/src/kudu/tablet/tablet.h@630 PS1, Line 630: *comps = CHEC > nit: it seems this will emit some warnings about non-used return > value. > > Maybe, use just > > CHECK(components_.get()) or CHECK_NE(nullptr, components_.get())? Ohh, you're right. I think '*comps = CHECK_NOTNULL(components_.get()); ' might be better. :) -- To view, visit http://gerrit.cloudera.org:8080/13750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2eb6a268429741ad3609647dc1a73edec495ff2 Gerrit-Change-Number: 13750 Gerrit-PatchSet: 2 Gerrit-Owner: Yao Xu <ocla...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <ocla...@gmail.com> Gerrit-Comment-Date: Tue, 02 Jul 2019 03:34:18 +0000 Gerrit-HasComments: Yes
