Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 )
Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13721/2/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: http://gerrit.cloudera.org:8080/#/c/13721/2/src/kudu/common/wire_protocol.cc@935 PS2, Line 935: select_row_idx->resize(select_row_idx->size() + run_size); I think it would be better to save the selected row idx boundary instead of all the selected row idx. http://gerrit.cloudera.org:8080/#/c/13721/2/src/kudu/common/wire_protocol.cc@999 PS2, Line 999: const ColumnBlock column_block const ColumnBlock& column_block -- To view, visit http://gerrit.cloudera.org:8080/13721 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19917d1875c46fd4cf98ef8a471b0340a76161e7 Gerrit-Change-Number: 13721 Gerrit-PatchSet: 2 Gerrit-Owner: ZhangYao <triplesheep0...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Yao Xu <ocla...@gmail.com> Gerrit-Reviewer: ZhangYao <triplesheep0...@gmail.com> Gerrit-Comment-Date: Wed, 10 Jul 2019 10:27:47 +0000 Gerrit-HasComments: Yes
