helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13821 )
Change subject: KUDU-2855 Lazy-create DeltaMemStore on first update ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13821/2/src/kudu/tablet/delta_tracker.h File src/kudu/tablet/delta_tracker.h: http://gerrit.cloudera.org:8080/#/c/13821/2/src/kudu/tablet/delta_tracker.h@336 PS2, Line 336: const scoped_refptr<log::LogAnchorRegistry> log_anchor_registry_; > Those test-only cases look like lazy programming. Let's fix them, and then No, I will fix them. ^_^ By the way, a raw pointer here has a potential risk for the next users or test cases if he or she doesn't know how log_anchor_registry_ works. -- To view, visit http://gerrit.cloudera.org:8080/13821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0c565d86647d5144266b30aa6e8572d42db48c6 Gerrit-Change-Number: 13821 Gerrit-PatchSet: 3 Gerrit-Owner: helifu <hzhel...@corp.netease.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Wed, 10 Jul 2019 22:27:17 +0000 Gerrit-HasComments: Yes
