Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13875 )
Change subject: KUDU-2823 [java client] Support setting dimension for the newly created tablet ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13875/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS2: > The cluster balancer part you're alluding to is something you're > still developing right? Okay, at least now I understand the > motivation for wanting to include the label on lookups. Yes, I think I might finish it next week. http://gerrit.cloudera.org:8080/#/c/13875/2/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/13875/2/src/kudu/master/master.proto@375 PS2, Line 375: optional string dimension_label = 3; > There's a TODO there about switching to a new structure. Could you > address it? Seems like we should convert to a POJO that looks like > a ReplicaPB but isn't actually used on the wire in the way that > ReplicaPB is. Sure, I'm willing to give it a try. :) Maybe we can drop ReplicaPB from the project. Btw, do you think this patch can be merged now? Or wait until we drop the ReplicaPB? -- To view, visit http://gerrit.cloudera.org:8080/13875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fc7797011df578000544147938bd15a6027f4c8 Gerrit-Change-Number: 13875 Gerrit-PatchSet: 4 Gerrit-Owner: Yao Xu <ocla...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <ocla...@gmail.com> Gerrit-Comment-Date: Fri, 19 Jul 2019 03:24:36 +0000 Gerrit-HasComments: Yes
