Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 )
Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 ...................................................................... Patch Set 23: (1 comment) > Patch Set 22: > > Due to the variable length nature of UTF8 and the columnar format I believe > it makes most sense to implement it the same way as Impala did, only wanted > to bring your attention to this discrepancy. This is all super useful design trade off information. Could you try to summarize it into the commit message? http://gerrit.cloudera.org:8080/#/c/13760/23//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13760/23//COMMIT_MSG@23 PS23, Line 23: 65,353 Did you mean 65535 here? -- To view, visit http://gerrit.cloudera.org:8080/13760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I998982dba93831db91c43a97ce30d3e68c2a4a54 Gerrit-Change-Number: 13760 Gerrit-PatchSet: 23 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Mon, 22 Jul 2019 19:01:55 +0000 Gerrit-HasComments: Yes
