Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14061 )
Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14061/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14061/2//COMMIT_MSG@38 PS2, Line 38: This is because there is DeltaTracker lack of lock protection when modify : the number of live rows in rowset_metadata_ and reset the deleted_row_count_. : This caused deleted_row_count_ to be duplicated when calculating the number : of live rows of DRS. > It took me a while to understand the race. Below is a thread interleaving t Well, it's really clear. Got a new skill !! http://gerrit.cloudera.org:8080/#/c/14061/2/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: http://gerrit.cloudera.org:8080/#/c/14061/2/src/kudu/tablet/delta_tracker.cc@746 PS2, Line 746: RETURN_NOT_OK(rowset_metadata_->CommitRedoDeltaDataBlock(dms->id(), block_id)); > Is it problematic that the live row count isn't changed atomically as part Mmm, this is a real problem, and I'll try to add some test cases to my integration tests. Great Thanks :) -- To view, visit http://gerrit.cloudera.org:8080/14061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bb4456123087778c9dc799777c5990938a84fdf Gerrit-Change-Number: 14061 Gerrit-PatchSet: 2 Gerrit-Owner: Yao Xu <ocla...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <ocla...@gmail.com> Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Thu, 15 Aug 2019 03:44:06 +0000 Gerrit-HasComments: Yes
