Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14018 )
Change subject: Prepare for upgrading to Hive 3 ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/14018/5/src/kudu/hms/mini_hms.cc File src/kudu/hms/mini_hms.cc: http://gerrit.cloudera.org:8080/#/c/14018/5/src/kudu/hms/mini_hms.cc@156 PS5, Line 156: { "HADOOP_CONF_DIR", data_root_ }, Is the a duplicate for line 152? http://gerrit.cloudera.org:8080/#/c/14018/5/src/kudu/hms/mini_hms.cc@158 PS5, Line 158: TODO(ghenke) nit: maybe, replace with TODO(HADOOP-15966): remove after the issue is addressed (Hadoop 3.1.3+) ? -- To view, visit http://gerrit.cloudera.org:8080/14018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69 Gerrit-Change-Number: 14018 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 15 Aug 2019 20:01:23 +0000 Gerrit-HasComments: Yes
