Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14085 )
Change subject: Minor update to kudu-tool-test for macOS. ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc@627 PS1, Line 627: } > warning: the 'empty' method should be used to check for emptiness instead o Done http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc@4922 PS1, Line 4922: "address for bad: Name or service not known"))); : #endif : } : : TEST_F(ToolTest, ClusterNameResolverNormal) { : ExternalMiniClusterOptions opts; > Rather than bake the possibility of up to two errors into the code, use the Done http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc@4926 PS1, Line 4926: meResolverNormal) { : ExternalMiniClusterOptions opts; > maybe, just match the error message with shorter string Done -- To view, visit http://gerrit.cloudera.org:8080/14085 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e Gerrit-Change-Number: 14085 Gerrit-PatchSet: 2 Gerrit-Owner: Hannah Nguyen <hannah.ngu...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Hannah Nguyen <hannah.ngu...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 16 Aug 2019 23:55:34 +0000 Gerrit-HasComments: Yes
