Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14107 )
Change subject: KUDU-2921: Exposing the table statistics to spark relation. ...................................................................... Patch Set 4: > 1. For java client when using new RPC: > new java client -> old server -> leads to execption OK, because the exception is only seen when invoking the new APIs. It's not visible in any existing APIs, right? > 2. For spark client: > new spark client depends on new java client. > new spark client -> old server -> leads to execption This is what concerns me. Under what circumstances is there an exception? When invoking some new API? Or in existing data paths? If the latter, we need to address it. We take great care to ensure Kudu is both forward and backward compatible, whether it be across the wire (i.e. between server and client), or across a library boundary (i.e. between client and application). It wouldn't be OK for someone running with the new Spark integration against an old server to have a degraded experience in _existing_ functionality. If it's brand new functionality (i.e. a new API in the client), that's fine. -- To view, visit http://gerrit.cloudera.org:8080/14107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7742a76708f989b0ccc8ba417f3390013e260175 Gerrit-Change-Number: 14107 Gerrit-PatchSet: 4 Gerrit-Owner: ZhangYao <triplesheep0...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: ZhangYao <triplesheep0...@gmail.com> Gerrit-Comment-Date: Fri, 30 Aug 2019 00:30:18 +0000 Gerrit-HasComments: No
