Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13987 to look at the new patch set (#2). Change subject: KUDU-2854 short circuit predicates on dictionary-coded columns ...................................................................... KUDU-2854 short circuit predicates on dictionary-coded columns 1. A dictionary encoding column has no updates in DRS, if there are not entries in the dictionary match the predicate: a) Skip the whole DRS when a flag in the cfile footer is true which indicates that all blocks are dict-coded; b) Skip any front dict-coded blocks without decoding the dictionary words; 2. A dictionary encoding column has updates in DRS, if there are not deltas any more during scanning and the entries in the dictionary doesn't match the predicates: a) Skip all of the remaining dict-coded blocks when the flag in the cfile footer is true; b) Skip the remaining dict-coded blocks without decoding the dictionary words; Change-Id: Id348583cc7d85773e8f32a189f4344d7a36a30b6 --- M src/kudu/cfile/binary_dict_block.h M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/cfile.proto M src/kudu/cfile/cfile_reader.cc M src/kudu/cfile/cfile_reader.h M src/kudu/cfile/cfile_writer.cc M src/kudu/cfile/cfile_writer.h M src/kudu/common/column_materialization_context.h M src/kudu/tablet/cfile_set.cc M src/kudu/tablet/delta_applier.cc M src/kudu/tablet/delta_iterator_merger.cc M src/kudu/tablet/delta_iterator_merger.h M src/kudu/tablet/delta_store.cc M src/kudu/tablet/delta_store.h M src/kudu/tablet/deltafile.cc M src/kudu/tablet/deltafile.h M src/kudu/tablet/deltamemstore.cc M src/kudu/tablet/deltamemstore.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/tablet-test-util.h 20 files changed, 641 insertions(+), 38 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/13987/2 -- To view, visit http://gerrit.cloudera.org:8080/13987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id348583cc7d85773e8f32a189f4344d7a36a30b6 Gerrit-Change-Number: 13987 Gerrit-PatchSet: 2 Gerrit-Owner: helifu <hzhel...@corp.netease.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <hzhel...@corp.netease.com>