Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14193 )
Change subject: [documentation] Adde alternative recommendation to deal with Kudu source code indexing in Eclipse ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/14193/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14193/1//COMMIT_MSG@7 PS1, Line 7: [documentation] [docs] http://gerrit.cloudera.org:8080/#/c/14193/1//COMMIT_MSG@7 PS1, Line 7: Adde alternative recommendation to deal with Kudu source : code indexing in Eclipse For writing commit messages, please follow the recommendations at https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines How about the following for summary: recommendation on Kudu code indexing in Eclipse http://gerrit.cloudera.org:8080/#/c/14193/1/README.adoc File README.adoc: http://gerrit.cloudera.org:8080/#/c/14193/1/README.adoc@438 PS1, Line 438: Project Explorer nit: at the text above, I can see that particular menu items, tabs, other elements of UI are referenced as "TabX" or "Menu Item Y" (i.e. their names are in quotes). Could you use the same notation here? http://gerrit.cloudera.org:8080/#/c/14193/1/README.adoc@439 PS1, Line 439: Languege Language http://gerrit.cloudera.org:8080/#/c/14193/1/README.adoc@441 PS1, Line 441: [3] I'm not sure it's clear what to do here. Does choosing 'Preproccor Macro' does all what's needed? Or it's necessary to follow the instructions at [3] to find out what to do and get the necessary macros? NOTE: I'm not using Eclipse, so maybe that's self-evident; just making sure it is what it's supposed to be. -- To view, visit http://gerrit.cloudera.org:8080/14193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia214e536ff3a7ddafb3ab969b50ed5f97f4c725a Gerrit-Change-Number: 14193 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 06 Sep 2019 23:33:08 +0000 Gerrit-HasComments: Yes
