Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14193 )
Change subject: [docs] Kudu source code indexing in Eclipse ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/14193/1/README.adoc File README.adoc: http://gerrit.cloudera.org:8080/#/c/14193/1/README.adoc@441 PS1, Line 441: " [ > Ah, I see. If that's clear enough for a user of the Eclipse IDE, then I'm Agreed with Alexey that the list of macros to add is non-obvious. Could you add some sort of guidance? Something like "you may encounter a variety of red squigglies [I used that silly term earlier, so repetition will help with understanding] due to Eclipse's poor macro discovery. Whenever this happens, ..." BTW, I don't recall having to do this when I used Eclipse CDT. I distinctly remember seeing KUDU_HEADERS_USE_SHORT_STATUS_MACROS (and other macros) properly listed in the project settings. But I guess that might be due to something different between our setups. http://gerrit.cloudera.org:8080/#/c/14193/4/README.adoc File README.adoc: http://gerrit.cloudera.org:8080/#/c/14193/4/README.adoc@432 PS4, Line 432: Another way to approach enormous source code indexing in Ecplise is to get rid of > This doesn't need to be done in this change, but I am curious if there is a The problem is that the Eclipse config is auto-generated from cmake. If we were to check it in, it'd slowly get more and more stale as the cmake logic evolves. -- To view, visit http://gerrit.cloudera.org:8080/14193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia214e536ff3a7ddafb3ab969b50ed5f97f4c725a Gerrit-Change-Number: 14193 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 10 Sep 2019 04:42:12 +0000 Gerrit-HasComments: Yes
