Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14192 )
Change subject: [examples] Example shell scripts to start and stop Kudu cluster ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/14192/6/examples/quickstart/scripts/start_kudu.sh File examples/quickstart/scripts/start_kudu.sh: http://gerrit.cloudera.org:8080/#/c/14192/6/examples/quickstart/scripts/start_kudu.sh@95 PS6, Line 95: # Start master server with RPC port 8765 and HTTP port 8764 : start_master 8765 8764 : # Start tablet server with RPC port 9870, HTTP port 9871 and master port 8765 : start_tserver tserver-0 9870 9871 8765 : start_tserver tserver-1 9872 9873 8765 : start_tserver tserver-2 9874 9875 8765 > Maybe you could allow the ports to be configurable via env variables? Seems I agree with Adar -- it's better have a way to configure, say, 'base port number' and start from there. The ports numbers might be derived from the base port and the index of tablet server. For example, I use the following approach in my scripts: MASTER_RPC_PORT=8765 RPC_PORT_BASE=9870 HTTP_PORT_BASE=9871 RPC_PORT=$((2 * $IDX + $RPC_PORT_BASE)) HTTP_PORT=$((2 * $IDX + $HTTP_PORT_BASE)) -- To view, visit http://gerrit.cloudera.org:8080/14192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e7bb66d4cce84d00d346bf50154f449d48e7a54 Gerrit-Change-Number: 14192 Gerrit-PatchSet: 6 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2019 16:44:47 +0000 Gerrit-HasComments: Yes
