Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14222 )
Change subject: KUDU-2069 p4: stop replication from failed servers in maintenance mode ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/14222/2/src/kudu/consensus/quorum_util.h File src/kudu/consensus/quorum_util.h: http://gerrit.cloudera.org:8080/#/c/14222/2/src/kudu/consensus/quorum_util.h@122 PS2, Line 122: there are enough replicas available there is a quorum http://gerrit.cloudera.org:8080/#/c/14222/2/src/kudu/consensus/quorum_util.h@132 PS2, Line 132: std::unordered_set<std::string>() nit: would '{}' suffice here instead of 'std::unordered_set<std::string>()' ? http://gerrit.cloudera.org:8080/#/c/14222/2/src/kudu/consensus/quorum_util.cc File src/kudu/consensus/quorum_util.cc: http://gerrit.cloudera.org:8080/#/c/14222/2/src/kudu/consensus/quorum_util.cc@456 PS2, Line 456: peer.attrs().replace() Do we want to avoid replacing replicas from nodes in maintenance mode? As I understand, the intent of the REPLACE attribute is inline with whatever maintenance mode is currently trying to do. Especially, if thinking about moving replicas from a node switched into the maintenance mode, there is no other way to remove replica with the 3-4-3 replica management scheme but mark the source replica with the REPLACE attribute and add a new non-voter replica in the same Raft transaction. -- To view, visit http://gerrit.cloudera.org:8080/14222 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a63b55011d16900c0d27eac0eb75880074204db Gerrit-Change-Number: 14222 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 13 Sep 2019 05:06:23 +0000 Gerrit-HasComments: Yes
