Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14263 )
Change subject: KUDU-2842: don't reference CowLock state from TSInfosDict ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14263/2/src/kudu/gutil/map-util.h File src/kudu/gutil/map-util.h: http://gerrit.cloudera.org:8080/#/c/14263/2/src/kudu/gutil/map-util.h@892 PS2, Line 892: pb What's "pb"? Was it previous name for "s"? http://gerrit.cloudera.org:8080/#/c/14263/2/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/14263/2/src/kudu/integration-tests/ts_tablet_manager-itest.cc@390 PS2, Line 390: latch.CountDown(); : if (t) { : NO_FATALS(t->join()); : } nit: add this into a scoped clean-up -- this is to properly clean up if anything after spawning the thread, but before these lines fails -- To view, visit http://gerrit.cloudera.org:8080/14263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30f4cd2eb8439e1923c1c2617248514354561d16 Gerrit-Change-Number: 14263 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 20 Sep 2019 01:34:24 +0000 Gerrit-HasComments: Yes
