Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#29). Change subject: KUDU-1938 Add support for CHAR pt 1 ...................................................................... KUDU-1938 Add support for CHAR pt 1 Introduces the CHAR data type to the server. Follow up commits will add integration to the clients. The CHAR type is parameterized with a length column type attribute similar to DECIMAL's scale and precision. Internally it's stored as BINARY. The maximum length for VARCHAR is 65,535 characters. If a value longer than the "n" is submitted for a VARCHAR(n) column the value is truncated to "n" characters before persisting the data on the server side. The maximum length was chosen for compatibility reasons. Apache Impala has a maximum length of 65,535 *bytes* for VARCHAR and major RDBMSs I checked also have a similar limits either in characters or bytes, mostly configurable. Change-Id: I998982dba93831db91c43a97ce30d3e68c2a4a54 --- M src/kudu/common/column_predicate-test.cc M src/kudu/common/common.proto M src/kudu/common/partial_row-test.cc M src/kudu/common/partial_row.cc M src/kudu/common/partial_row.h M src/kudu/common/schema.cc M src/kudu/common/schema.h M src/kudu/common/types.cc M src/kudu/common/types.h M src/kudu/common/wire_protocol.cc M src/kudu/util/CMakeLists.txt A src/kudu/util/char_util.cc A src/kudu/util/char_util.h 13 files changed, 258 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/13760/29 -- To view, visit http://gerrit.cloudera.org:8080/13760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I998982dba93831db91c43a97ce30d3e68c2a4a54 Gerrit-Change-Number: 13760 Gerrit-PatchSet: 29 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>