Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14333 )

Change subject: KUDU-1938 Add range partition support pt 6
......................................................................


Patch Set 1:

> Patch Set 1:
>
> Is this all that is needed to allow for VARCHAR to be used in partition keys? 
> If so, could you prove it with end-to-end C++ and Java tests?

it seems it is, I just ran the tests on Impala that creates range partitions on 
it (which is how I noticed it didn't work). I didn't see any end-to-end tests 
for other types, thought testing it in partition-test.cc would be enough. I'll 
add end-to-end tests to this commit, pushing it now without them as I just 
finished rebasing the other commits.

>
> I pushed http://gerrit.cloudera.org:8080/14335 for the (unrelated) test 
> failure.

Thanks


--
To view, visit http://gerrit.cloudera.org:8080/14333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
Gerrit-Change-Number: 14333
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Oct 2019 19:42:59 +0000
Gerrit-HasComments: No

Reply via email to