Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14303 )
Change subject: KUDU-1938 [hms] Add HMS support for VARCHAR pt 5 ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/14303/5/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/14303/5/src/kudu/hms/hms_catalog.cc@333 PS5, Line 333: case VARCHAR: return "varchar"; What about the length attribute? In decimal above we add the attributes in parenthesis. -- To view, visit http://gerrit.cloudera.org:8080/14303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If929bd14eb8d1b2e54ea7892c2f85a3b1305c05d Gerrit-Change-Number: 14303 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 02 Oct 2019 14:00:57 +0000 Gerrit-HasComments: Yes
