Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14379 )
Change subject: WIP [tests] use system_unsync time source for tests by default ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14379/1/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/14379/1/src/kudu/util/test_util.cc@133 PS1, Line 133: FLAGS_time_source = UseSystemNtp() ? "system" : "system_unsync"; > I tried IsGTest() to set the default value for time_source, and it works if If you set the default value for FLAGS_time_source programmatically, you can tell gflags just to change its default value rather than its current value. That'll allow users to continue to set --time_source on the command line for tests and override whatever we stipulate in the IsGTest() block. -- To view, visit http://gerrit.cloudera.org:8080/14379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7edbf884afaa19121aa92a4ce93c8a7eeb2d937 Gerrit-Change-Number: 14379 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 08 Oct 2019 03:41:22 +0000 Gerrit-HasComments: Yes
