Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14393 )
Change subject: webserver: port fix for IMPALA-9001 to Kudu ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14393/1/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/14393/1/src/kudu/server/webserver.cc@143 PS1, Line 143: If authentication fails or the header : // is invalid, a bad Status will be returned (and the other out-parameters left untouched). Could you update this in-line doc to reflect the fix? http://gerrit.cloudera.org:8080/#/c/14393/1/src/kudu/server/webserver.cc@148 PS1, Line 148: static const char* kNegotiateStr nit: static const char* const kNegotiateStr ? -- To view, visit http://gerrit.cloudera.org:8080/14393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9231677beb5990772736cf349c88f4b2b3344a7c Gerrit-Change-Number: 14393 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Wed, 09 Oct 2019 01:38:28 +0000 Gerrit-HasComments: Yes
