Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14380 )
Change subject: [cfile] KUDU-2852 Push predicate evaluation for int type RLE decoder ...................................................................... Patch Set 2: (2 comments) I just took a quick first look. http://gerrit.cloudera.org:8080/#/c/14380/4/src/kudu/cfile/rle_block.h File src/kudu/cfile/rle_block.h: http://gerrit.cloudera.org:8080/#/c/14380/4/src/kudu/cfile/rle_block.h@426 PS4, Line 426: virtual nit: drop virtual since it's already an override http://gerrit.cloudera.org:8080/#/c/14380/4/src/kudu/cfile/rle_block.h@450 PS4, Line 450: void * nit: void* (stick the asterisk to the type) -- To view, visit http://gerrit.cloudera.org:8080/14380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e05775ec1301d3d0b0365a7704b8e962a20455e Gerrit-Change-Number: 14380 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 10 Oct 2019 21:31:57 +0000 Gerrit-HasComments: Yes
