Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14419 )
Change subject: util: gscoped_ptr<ThreadPool> -> unique_ptr<ThreadPool> ...................................................................... Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/14419/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14419/1//COMMIT_MSG@15 PS1, Line 15: should be no It sounds like you are not quite sure? :) http://gerrit.cloudera.org:8080/#/c/14419/1/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/14419/1/src/kudu/util/threadpool.cc@128 PS1, Line 128: RETURN_NOT_OK((*pool)->Init()); : return Status::OK(); nit: while you are at it, maybe you could merge these two lines into return (*pool)->Init(); ? -- To view, visit http://gerrit.cloudera.org:8080/14419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983 Gerrit-Change-Number: 14419 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Sat, 12 Oct 2019 00:50:50 +0000 Gerrit-HasComments: Yes
