Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14425 )
Change subject: KUDU-2971 p1: add subprocess module ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/14425/1/src/kudu/subprocess/subprocess_protocol.h File src/kudu/subprocess/subprocess_protocol.h: http://gerrit.cloudera.org:8080/#/c/14425/1/src/kudu/subprocess/subprocess_protocol.h@25 PS1, Line 25: class faststring; // NOLINT > warning: invalid case style for class 'faststring' [readability-identifier- Done http://gerrit.cloudera.org:8080/#/c/14425/1/src/kudu/subprocess/subprocess_protocol.cc File src/kudu/subprocess/subprocess_protocol.cc: http://gerrit.cloudera.org:8080/#/c/14425/1/src/kudu/subprocess/subprocess_protocol.cc@39 PS1, Line 39: using strings::Substitute; > warning: using decl 'SecureShortDebugString' is unused [misc-unused-using-d Done http://gerrit.cloudera.org:8080/#/c/14425/1/src/kudu/subprocess/subprocess_protocol.cc@40 PS1, Line 40: using std::string; > warning: using decl 'ControlShellRequestPB' is unused [misc-unused-using-de Done http://gerrit.cloudera.org:8080/#/c/14425/1/src/kudu/subprocess/subprocess_protocol.cc@41 PS1, Line 41: > warning: using decl 'ControlShellResponsePB' is unused [misc-unused-using-d Done -- To view, visit http://gerrit.cloudera.org:8080/14425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If73e27772e1897a04f04229c4906a24c61e361f2 Gerrit-Change-Number: 14425 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 14 Oct 2019 17:34:45 +0000 Gerrit-HasComments: Yes
