YangSong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14306 )
Change subject: add a tool to create table ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/14306/16/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/14306/16/src/kudu/tools/tool.proto@342 PS16, Line 342: // The encoding type of column. Default type is "AUTO_ENCODING", the types : // "PLAIN_ENCODING", "PREFIX_ENCODING", "GROUP_VARINT", "RLE", : // "DICT_ENCODING", "BIT_SHUFFLE" are also supported. : optional string encoding = 6; : // The compression of column. Default type is "DEFAULT_COMPRESSION", the : // types "NO_COMPRESSION", "SNAPPY", "LZ4", "ZLIB" are also supported. : optional string compression = 7; > Hmm, we should actually use PB enums for these, as we did for RangePartitio If using PB enums, it maybe looks user-unfriendly. -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 17 Gerrit-Owner: YangSong <sy1...@yeah.net> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <sy1...@yeah.net> Gerrit-Comment-Date: Wed, 16 Oct 2019 03:25:55 +0000 Gerrit-HasComments: Yes