Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14503 )
Change subject: WIP: fix ORDERED scan regression when scanned columns are out-of-order ...................................................................... Patch Set 1: (2 comments) I took a quick look: my feedback is not about the essence of the change, but some nits. http://gerrit.cloudera.org:8080/#/c/14503/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/14503/1/src/kudu/client/client-test.cc@6379 PS1, Line 6379: CDH82238 nit: maybe, turn this into something upstream-like? http://gerrit.cloudera.org:8080/#/c/14503/1/src/kudu/client/client-test.cc@6380 PS1, Line 6380: KuduSchemaBuilder b; nit: maybe replace the column names with something not field-specific? -- To view, visit http://gerrit.cloudera.org:8080/14503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb213f466c7d01b6953a863d8aa53a34b5ac8893 Gerrit-Change-Number: 14503 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 18 Oct 2019 02:57:23 +0000 Gerrit-HasComments: Yes
