Hello Yifan Zhang, Kudu Jenkins, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14507 to look at the new patch set (#2). Change subject: [metrics] Hide metric live_row_count when tablet not support ...................................................................... [metrics] Hide metric live_row_count when tablet not support When upgrade an tserver from version older than 1.11, and add some partitions for an existing table, then the table will hold some tablets that support live row counting together with some ones that not support. Tablet which not support live row counting has value of -1, in this case, metrics merge on tserver and metrics aggregate on master have problems. This patch add feature to validate metric when happend to see an invalid metric when MergeFrom, and change 'live_row_count' to 'assured_live_row_count' on master. Change-Id: I2a54704d8cbd64a521e65aa3e95bf1a68f7757b7 --- M src/kudu/integration-tests/ts_tablet_manager-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master_path_handlers.cc M src/kudu/master/table_metrics.cc M src/kudu/master/table_metrics.h M src/kudu/tablet/metadata.proto M src/kudu/tablet/mt-tablet-test.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet_replica-test.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/tablet/tablet_replica.h M src/kudu/util/metrics.cc M src/kudu/util/metrics.h 16 files changed, 111 insertions(+), 49 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/14507/2 -- To view, visit http://gerrit.cloudera.org:8080/14507 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2a54704d8cbd64a521e65aa3e95bf1a68f7757b7 Gerrit-Change-Number: 14507 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: helifu <hzhel...@corp.netease.com>