Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14518 )
Change subject: [fs] Fix possible overflow when calculate max_open_files ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14518/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14518/2//COMMIT_MSG@13 PS2, Line 13: In addition, 40% of any value of the `uint64_t` type must be : less than `kint64max`, so there is no need to cap rlimit. I'd prefer you kept the cap, so that if someone adjusts the 40% in the future (to, say 60%) they won't accidentally introduce the possibility of an overflow. -- To view, visit http://gerrit.cloudera.org:8080/14518 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8 Gerrit-Change-Number: 14518 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 21 Oct 2019 18:11:28 +0000 Gerrit-HasComments: Yes
