Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14507 )
Change subject: [metrics] Hide metric live_row_count when tablet not support ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/14507/13/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14507/13/src/kudu/master/catalog_manager.cc@5587 PS13, Line 5587: // The new reported stat doesn't support 'live_row_count' and : // this is the first report stat of the tablet. I asked about this in PS12: if there is a ReportedTabletStatsPB in the tablet report, isn't on_disk_size always set? -- To view, visit http://gerrit.cloudera.org:8080/14507 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a54704d8cbd64a521e65aa3e95bf1a68f7757b7 Gerrit-Change-Number: 14507 Gerrit-PatchSet: 13 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Wed, 23 Oct 2019 03:52:37 +0000 Gerrit-HasComments: Yes