Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14154 )
Change subject: KUDU-2914: Rebalance tool support moving replicas from some specific tablet servers ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/14154/10/src/kudu/rebalance/rebalancer.h File src/kudu/rebalance/rebalancer.h: http://gerrit.cloudera.org:8080/#/c/14154/10/src/kudu/rebalance/rebalancer.h@70 PS10, Line 70: If empty, run the rebalancing on : // all tablet servers in the cluster. Would it be beneficial to have the option to choose the former default behavior of the rebalancer tool to not do rebalancing if there are any or some specified number of unhealthy tservers? What if there are enough healthy tservers to maintain the RF and run rebalancing, but there are also a significant number of unhealthy tservers? Could the rebalancer tool end up moving replicas that will make the cluster imbalanced, and have to be moved again, once the unhealthy tservers become available again? http://gerrit.cloudera.org:8080/#/c/14154/10/src/kudu/tools/rebalancer_tool.cc File src/kudu/tools/rebalancer_tool.cc: http://gerrit.cloudera.org:8080/#/c/14154/10/src/kudu/tools/rebalancer_tool.cc@631 PS10, Line 631: CheckIgnoredServers Is this function only called when move_replicas_from_ignored_tservers=true? When move_replicas_from_ignored_tservers=false, Rebalancer::BuildClusterInfo() still populates ignored_tservers with unhealthy tservers. We should still verify that remaining_tservers_count >= max_replication_factor, even if not moving replicas from the ignored tservers. -- To view, visit http://gerrit.cloudera.org:8080/14154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86cfb740030946c13db1a9ca63d241f4907d6c89 Gerrit-Change-Number: 14154 Gerrit-PatchSet: 10 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hannah Nguyen <hannah.ngu...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Comment-Date: Thu, 24 Oct 2019 16:10:18 +0000 Gerrit-HasComments: Yes
