Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14598 )
Change subject: [spark] Add prefetching option to kudu-spark ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Thanks for finding and fixing this bug. Could we break this into two patches for clarity? The first patch should fix exposing prefetching in the scan token, and the second should expose prefetching to spark. http://gerrit.cloudera.org:8080/#/c/14598/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14598/1//COMMIT_MSG@11 PS1, Line 11: can be greatly reduced in some scenarios. Therefore, I added prefetching Out of curiosity, have you seen a performance increase when using pre-fetching? Do you have a quantified example? Should we consider setting the default to true? why or why not? -- To view, visit http://gerrit.cloudera.org:8080/14598 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If48735d693ad560f96e8cd5781eff916c06b8aa8 Gerrit-Change-Number: 14598 Gerrit-PatchSet: 1 Gerrit-Owner: Yao Xu <ocla...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 31 Oct 2019 13:27:21 +0000 Gerrit-HasComments: Yes
