Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14642 )
Change subject: [master] KUDU-2904 Crash master on disk error ...................................................................... Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/14642/3/src/kudu/integration-tests/disk_failure-itest.cc File src/kudu/integration-tests/disk_failure-itest.cc: http://gerrit.cloudera.org:8080/#/c/14642/3/src/kudu/integration-tests/disk_failure-itest.cc@363 PS3, Line 363: ASSERT_OK(leader_master->WaitForFatal(MonoDelta::FromSeconds(4))); This timeout value seems oddly specific, and potentially too low in a TSAN environment. Have you tried looping the test in TSAN mode, possibly with some additional stress threads (--stress_cpu_threads)? I'm guessing we'll want to raise it to something like 20 or 30. http://gerrit.cloudera.org:8080/#/c/14642/3/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/14642/3/src/kudu/master/master.cc@302 PS3, Line 302: std:: Nit: remove prefix -- To view, visit http://gerrit.cloudera.org:8080/14642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I693eb7092c0b5feb530fb011937e636b40534495 Gerrit-Change-Number: 14642 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 Nov 2019 08:15:29 +0000 Gerrit-HasComments: Yes
