Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14555 )
Change subject: KUDU-2977 Sharding block map to speed up tserver startup ...................................................................... Patch Set 5: > Patch Set 5: > > > Patch Set 5: > > > > > Patch Set 5: > > > > > > The TSAN failure looks real but I don't know what's causing it. > > > > > > Look more about sparsepp project https://github.com/greg7mdp/sparsepp, I > > found this data race issuse has been fixed, by commit: > > commit e6aad301c37a69c7b91e0f437ee525c0a72062d4 > > Author: Breno Rodrigues Guimaraes <bren...@gmail.com> > > Date: Sun Oct 22 07:35:33 2017 -0700 > > > > Avoid data race on initialization of s_alloc_batch_sz > > > > I think we should update this thirdparty library. > > Good find. I agree; we should probably update to the latest commit. > > Alternatively, the author of sparspp now recommends > https://github.com/greg7mdp/parallel-hashmap, so we could switch to that > instead, though we should probably profile it first. OK, we'll do that some time later. And sparspp upgrade patch here https://gerrit.cloudera.org/c/14643, please take a review. -- To view, visit http://gerrit.cloudera.org:8080/14555 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0d5c13e051a2c1d6cfd1c9ad7db8a3cd195459d Gerrit-Change-Number: 14555 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Wed, 06 Nov 2019 09:24:09 +0000 Gerrit-HasComments: No
