Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14637 )
Change subject: [thirdparty] add license info about yaml-cpp and chrony ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14637/2/thirdparty/LICENSE.txt File thirdparty/LICENSE.txt: http://gerrit.cloudera.org:8080/#/c/14637/2/thirdparty/LICENSE.txt@689 PS2, Line 689: 3.5 > Nit: should be '*' so that it's not technically incorrect if/when we update Good catch. I was thinking to put the asterisk there (as in other entries in this file), but ended up with exact path for some reason. Fixed. -- To view, visit http://gerrit.cloudera.org:8080/14637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d Gerrit-Change-Number: 14637 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Wed, 06 Nov 2019 13:10:53 +0000 Gerrit-HasComments: Yes
