Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14713 )
Change subject: [java] fixed bug in the connection negotiation code ...................................................................... [java] fixed bug in the connection negotiation code This patch fixes a typo in the connection negotiation code in the Java client. Prior to this fix, channel binding information was not verified during connection negotiation because the peer certificate was not set. In addition, I modified the error handing code in Negotiator.java to abort connection negotiation upon receiving SSLPeerUnverifiedException due to the absence of the channel binding information or the presence of the invalid one. I also added a test to verify that Kudu Java client doesn't connect to a Kudu server which doesn't provide valid channel binding information during the connection negotiation phase. Kudos to Andy Singer for pointing to the bug. Change-Id: I7bfd428128e224f03901a6cd7b33283495a28d54 Reviewed-on: http://gerrit.cloudera.org:8080/14713 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <a...@cloudera.com> Reviewed-by: Todd Lipcon <t...@apache.org> --- M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java M src/kudu/rpc/server_negotiation.cc 4 files changed, 84 insertions(+), 3 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7bfd428128e224f03901a6cd7b33283495a28d54 Gerrit-Change-Number: 14713 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
