[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 )
Change subject: KUDU-2162 Expose stats about scan filters ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/8375/10/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java File java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java: http://gerrit.cloudera.org:8080/#/c/8375/10/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java@22 PS10, Line 22: import org.apache.yetus.audience.InterfaceStability; : > Don't need? Could you check the rest of the includes? Done http://gerrit.cloudera.org:8080/#/c/8375/10/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java@77 PS10, Line 77: return queueDurationNanos; : } : : /** : * Returns the total time taken for all scan rpc requests to complete in nanoseconds for this : * scanner : * @return long representing the total time taken for all scan rpc requests to complete in : * nanoseconds for this scanner : */ : public long getTotalDurationNanos() { : return totalDurationNanos; : } : : /** : * Returns total elapsed CPU user time in nanoseconds for this scan : * @return long representing the total elapsed CPU user time in nanoseconds for this scan : */ : > These two talk about "scan rpcs", but the values themselves are additive ac Done -- To view, visit http://gerrit.cloudera.org:8080/8375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30a7e82357fe2fc28f6d316378a612af43d8c96 Gerrit-Change-Number: 8375 Gerrit-PatchSet: 11 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sun, 17 Nov 2019 03:32:02 +0000 Gerrit-HasComments: Yes
