Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14426 )
Change subject: KUDU-2791 p2: add basic protobuf msg ...................................................................... Patch Set 2: (1 comment) > Patch Set 2: > > (1 comment) > > > Patch Set 1: > > > > (1 comment) > > > > Not really sure why this is its own patch. Seems like it should at least > > include a test or something. > > +1 I put it in a separate patch as both the following Java and c++ patch need to use the protobuf definition. But I can put it into the Java patch (which is large already) if you think that is better. http://gerrit.cloudera.org:8080/#/c/14426/1/src/kudu/subprocess/subprocess.proto File src/kudu/subprocess/subprocess.proto: http://gerrit.cloudera.org:8080/#/c/14426/1/src/kudu/subprocess/subprocess.proto@34 PS1, Line 34: // The request. > I think "any" is a proto3 feature. I don't see a good and easy way to repurpose the RPC "service" infrastructure so I choose to use the Any support, which different types of request won't be possible to mingle together. And Attila my understanding is we are using proto3, so any problem of using 'any'? -- To view, visit http://gerrit.cloudera.org:8080/14426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954 Gerrit-Change-Number: 14426 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 18 Nov 2019 18:03:02 +0000 Gerrit-HasComments: Yes
