Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 )
Change subject: Import Impala's blocked based BloomFilter ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/14745/2/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/14745/2/src/kudu/util/CMakeLists.txt@246 PS2, Line 246: set_source_files_properties(block_bloom_filter_avx2.cc PROPERTIES COMPILE_FLAGS "-mavx2") Hardcoding -mavx2 like this will cause problems in architectures that don't support AVX2. Should we take a page from bitshuffle and test for AVX2 support first? http://gerrit.cloudera.org:8080/#/c/14745/2/src/kudu/util/block_bloom_filter-test.cc File src/kudu/util/block_bloom_filter-test.cc: http://gerrit.cloudera.org:8080/#/c/14745/2/src/kudu/util/block_bloom_filter-test.cc@52 PS2, Line 52: void BfInsert(const std::shared_ptr<BlockBloomFilter>& bf, uint32_t h) { Consider adding using statements for this and the other STL usage in this file. http://gerrit.cloudera.org:8080/#/c/14745/2/src/kudu/util/block_bloom_filter-test.cc@96 PS2, Line 96: srand(0); Instead of these calls, consider SeedRandom() from KuduTest, which makes it easier to repro a test failure. http://gerrit.cloudera.org:8080/#/c/14745/2/src/kudu/util/block_bloom_filter.h File src/kudu/util/block_bloom_filter.h: http://gerrit.cloudera.org:8080/#/c/14745/2/src/kudu/util/block_bloom_filter.h@18 PS2, Line 18: #ifndef IMPALA_UTIL_BLOOM_H : #define IMPALA_UTIL_BLOOM_H Replace with #pragma once http://gerrit.cloudera.org:8080/#/c/14745/2/src/kudu/util/block_bloom_filter.h@39 PS2, Line 39: /// A BloomFilter stores sets of items and offers a query operation indicating whether or Nit: Kudu style uses double slashes for comments rather than triple slashes. http://gerrit.cloudera.org:8080/#/c/14745/2/src/kudu/util/block_bloom_filter.h@63 PS2, Line 63: class BloomFilterBufferAllocatorIf { : public: : virtual Status AllocateBuffer(size_t bytes, void **ptr) = 0; : virtual void FreeBuffer(void *ptr) = 0; : }; : : class DefaultBloomFilterBufferAllocator : public BloomFilterBufferAllocatorIf { : public: : // Required for Singleton : DefaultBloomFilterBufferAllocator() = default; : : Status AllocateBuffer(size_t bytes, void **ptr) override; : void FreeBuffer(void *ptr) override; : : static DefaultBloomFilterBufferAllocator* GetSingleton(); : private: : DISALLOW_COPY_AND_ASSIGN(DefaultBloomFilterBufferAllocator); : }; Should these class names also include the word Block? -- To view, visit http://gerrit.cloudera.org:8080/14745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c54a051c5093cf5fb81481a47a0a6677d7d906 Gerrit-Change-Number: 14745 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 22 Nov 2019 19:37:39 +0000 Gerrit-HasComments: Yes
