Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14983 )
Change subject: [tools] Fix create table tool for VARCHAR and DATE columns ...................................................................... [tools] Fix create table tool for VARCHAR and DATE columns When VARCHAR and DATE were added they weren’t added to KuduColumnSchema::StringToDataType. This means that they cant be used in the table tool to create a table. This patch adds VARCHAR and DATE to StringToDataType and test coverage to the create table tool tests. Change-Id: I249348e16dc06616b59ac92212a0a075aac2b2fa Reviewed-on: http://gerrit.cloudera.org:8080/14983 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <a...@cloudera.com> Reviewed-by: Volodymyr Verovkin <verjov...@cloudera.com> --- M src/kudu/client/schema.cc M src/kudu/tools/create-table-tool-test.cc M src/kudu/tools/tool.proto M src/kudu/tools/tool_action_table.cc 4 files changed, 34 insertions(+), 9 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved Volodymyr Verovkin: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/14983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I249348e16dc06616b59ac92212a0a075aac2b2fa Gerrit-Change-Number: 14983 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com>
