Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15032 )

Change subject: KUDU-3042: Fix invalid DCHECK when rpc is cancelled then times 
out
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15032/1/src/kudu/rpc/connection.cc
File src/kudu/rpc/connection.cc:

http://gerrit.cloudera.org:8080/#/c/15032/1/src/kudu/rpc/connection.cc@380
PS1, Line 380: The RPC may have been cancelled before the timeout was hit
Good find!

Is it possible to add a repro test scenario for this?  How do we know there 
aren't any other CHECKS/DCHECK() in the control path when this happens?



--
To view, visit http://gerrit.cloudera.org:8080/15032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b97ccc4787809fca8fbc991bb1151940477efca
Gerrit-Change-Number: 15032
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Tue, 14 Jan 2020 21:33:22 +0000
Gerrit-HasComments: Yes

Reply via email to