Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15018 )
Change subject: KUDU-2973 Normalize table names for Ranger ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/15018/4/src/kudu/common/table_util.cc File src/kudu/common/table_util.cc: http://gerrit.cloudera.org:8080/#/c/15018/4/src/kudu/common/table_util.cc@45 PS4, Line 45: "ABCDEFGHIJKLMNOPQRSTUVWXYZ" : "0123456789" : "_/"); Nit: indent by one more char it looks like. http://gerrit.cloudera.org:8080/#/c/15018/4/src/kudu/common/table_util.cc@57 PS4, Line 57: return -2; If this is a magic value, return an enum and pass the separator out by argument. -- To view, visit http://gerrit.cloudera.org:8080/15018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11431ff5bc75540edff56ef3d4ad384fa37d33d5 Gerrit-Change-Number: 15018 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 15 Jan 2020 21:45:39 +0000 Gerrit-HasComments: Yes
