Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15035 )
Change subject: KUDU-3011 p6: don't transfer leadership to quiescing followers ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/15035/3/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/15035/3/src/kudu/consensus/consensus_queue.cc@1143 PS3, Line 1143: if (response.has_server_quiescing()) { : peer->remote_server_quiescing = response.server_quiescing(); : } Do we expect transitions from the quiescent to the normal state? Is so, maybe either always populate the 'server_quiescing' field in the response or always update the peer's 'remote_server_quiescing' field? -- To view, visit http://gerrit.cloudera.org:8080/15035 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74ec79d0bc4dbe42fce0cca2e001cd0b369cd066 Gerrit-Change-Number: 15035 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 15 Jan 2020 22:37:10 +0000 Gerrit-HasComments: Yes
