Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15044
to review the following change.
Change subject: cfile: clean up encoding-test to use fewer templates
......................................................................
cfile: clean up encoding-test to use fewer templates
This test made heavy use of templates, which made things overly
complicated and hard to follow. All of the block builders/decoders
already implement common interfaces, so we can use runtime polymorphism
instead for the majority of code here.
This also cleans up the block builder/decoder factories to use
unique_ptr out-parameters instead of raw pointers.
Change-Id: Iba4464c2ea41107df96c68ea61576a0ea269277a
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/cfile/type_encodings.h
7 files changed, 239 insertions(+), 289 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/15044/1
--
To view, visit http://gerrit.cloudera.org:8080/15044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba4464c2ea41107df96c68ea61576a0ea269277a
Gerrit-Change-Number: 15044
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
