Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15043 )
Change subject: encoding-test: clean up bitshuffle tests a little ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15043/1/src/kudu/cfile/encoding-test.cc File src/kudu/cfile/encoding-test.cc: http://gerrit.cloudera.org:8080/#/c/15043/1/src/kudu/cfile/encoding-test.cc@719 PS1, Line 719: 1 Do we explicitly want it to have the same seed every run? http://gerrit.cloudera.org:8080/#/c/15043/1/src/kudu/cfile/encoding-test.cc@721 PS1, Line 721: for (int i = 0; i < count; i++) { nit: maybe, use the same 'for (auto& e : ints) ...' construct here as well? http://gerrit.cloudera.org:8080/#/c/15043/1/src/kudu/cfile/encoding-test.cc@742 PS1, Line 742: int32_t int64_t ? Or this is not a typo and it's necessary to have int32 limits for this test? -- To view, visit http://gerrit.cloudera.org:8080/15043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b7bee1f952c46c09df5102ac1916141c6935284 Gerrit-Change-Number: 15043 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 16 Jan 2020 02:46:37 +0000 Gerrit-HasComments: Yes
