Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15048 )
Change subject: [tserver] replace gscoped_ptr with unique_ptr in Scanner ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15048/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15048/1//COMMIT_MSG@10 PS1, Line 10: and avoid extra call to operator new > It's at https://gerrit.cloudera.org/#/c/15048/1/src/kudu/tserver/tablet_ser Oops, I reviewed the first two files but not the third. My bad. -- To view, visit http://gerrit.cloudera.org:8080/15048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieac533565f96773cc450de521703c21534020596 Gerrit-Change-Number: 15048 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 16 Jan 2020 06:00:06 +0000 Gerrit-HasComments: Yes