Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15055 )
Change subject: [metrics] fix compilation on macOS ...................................................................... Patch Set 1: > > Why doesn't this code in metrics.h address this? > > > > #if defined(__APPLE__) > > #define METRIC_DEFINE_gauge_size(entity, name, label, unit, desc, > > level, ...) \ > > ::kudu::GaugePrototype<size_t> METRIC_##name( > \ > > ::kudu::MetricPrototype::CtorArgs(#entity, #name, label, unit, > > desc, level, ## __VA_ARGS__)) > > #define METRIC_DECLARE_gauge_size(name) \ > > extern ::kudu::GaugePrototype<size_t> METRIC_##name > > #else > > #define METRIC_DEFINE_gauge_size METRIC_DEFINE_gauge_uint64 > > #define METRIC_DECLARE_gauge_size METRIC_DECLARE_gauge_uint64 > > #endif > > Because on macOS size_t isn't uint64_t. From the other side, maybe it's better to remove the custom specialization for macOS. -- To view, visit http://gerrit.cloudera.org:8080/15055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e7109aebec268db1d545e657c991e7791f85210 Gerrit-Change-Number: 15055 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Thu, 16 Jan 2020 22:44:10 +0000 Gerrit-HasComments: No
