Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14874 )
Change subject: memrowset: small optimizations for scanning ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/14874/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14874/5//COMMIT_MSG@33 PS5, Line 33: t-test Curious how do you run a t-test for a given gtest? http://gerrit.cloudera.org:8080/#/c/14874/5/src/kudu/tablet/cbtree-test.cc File src/kudu/tablet/cbtree-test.cc: http://gerrit.cloudera.org:8080/#/c/14874/5/src/kudu/tablet/cbtree-test.cc@759 PS5, Line 759: exact Nit: Since "exact" is not used, perhaps rename it to unused_exact? -- To view, visit http://gerrit.cloudera.org:8080/14874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3 Gerrit-Change-Number: 14874 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sat, 18 Jan 2020 00:41:33 +0000 Gerrit-HasComments: Yes
